Allow RegExp's with no-implicit-this #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Jan 8, 2019
There was a problem hiding this comment.
These changes look good, thanks for working on them!
Can you swap the test added to test/acceptance-test.js for one added in the no-implicit-this tests? Specifically, I think an additional good and bad scenario which include regexps would be all that we need...
|
This test for example: ember-template-lint/test/unit/rules/lint-no-implicit-this-test.js Lines 24 to 27 in 4b2cec3 |
rwjblue
force-pushed
the
add-regexp-to-allow-array
branch
from
d119ae2
to
4c33dfa
Compare
|
Sorry for the noise here, I just went ahead and made those changes for you. |
rwjblue
approved these changes
Jan 8, 2019
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule that permits
rules['no-implicit-this'].allowarray to include only strings prevents efficient work with ember-test-selectors (it is necessary to put all ofdata-test-*attributes in allow array, but this list may be large)