Model Doesn't Update After Create

[ghempton]

App.store.create App.person
    name: "John"

App.store.commit()

# Adapter saves data to server. Server returns newly created object that includes the id field. Adapter calls the didCreateModel method on the store.

{{#view App.PersonView contentBinding="this"}}
   {{#with content}}
     {{id}}
   {{/with}}
{{/view}}

The above view never updates with the correct id returned from the server.

[wycats]

Can I see your adapter?

[wycats]

Ah!

The problem is that you haven't declared id as a DS.attr. As a result, when the data changes, the model is never notified that the id property has changed. If you want to expose attributes from your models that you can observe, you need to do:

App.Person = DS.Model.extend
  id: DS.attr("integer")

[ghempton]

I tried that to no avail. Instead, the binding always shows NaN.

I notice that didCreateModel doesn't have a call to model.set('data', hash); and didCreateModels (plural) does have the call. Despite trying to add it, it still doesn't work.

Here is my store/adapter:

App.store = DS.Store.create
  adapter: DS.Adapter.create
    findAll: (store, type) ->
      url = type.collectionUrl
      $.getJSON url, (data) ->
        store.loadMany type, data
    create: (store, type, model) ->
      url = type.collectionUrl
      $.ajax
        data:
          resource: model.get('data')
        dataType: 'json'
        type: 'POST'
        url: url
        success: (data) ->
          console.log data
          store.didCreateModel model, data
    update: (store, type, model) ->
      url = type.url.fmt(model.get('id'))
      $.ajax
        data:
          resource: model.get('data')
        dataType: 'json'
        type: 'PUT'
        url: url
        success: (data) ->
          store.didUpdateModel model, data
    deleteModel: (store, type, model) ->
      url = type.url.fmt(model.get('id'))
      $.ajax
        data:
          resource: model.get('data')
        dataType: 'json'
        type: 'DELETE'
        url: url
        success: (data) ->
          store.didDeleteModel model

[wycats]

Hey. We fixed one issue in f548be3.

It seems as though there may have been several interrelated issues. Can you try again with id being a DS.attr and with the updated ember-data?

[ghempton]

I pulled the latest and tried again. Unfortunately the binding shows "NaN" (this bug aside, that seems like a poor default for an attribute). I will dig deeper into this issue early next week when I have more time. Thanks!

Out of curiosity, what is the difference between Ember.set(model, 'data', hash) and model.set('data', hash)?

[wycats]

Out of curiosity, what is the difference between Ember.set(model, 'data', hash) and model.set('data', hash)?

They are the same, but you can use Ember.set on an object that may be a regular JavaScript object:

foo = {}
Ember.set(foo, 'bar', 1)
foo //=> { bar: 1 }
foo.set('bar', 2) // no method set on foo

This is mostly useful if you want to support regular JavaScript objects in some context. In Ember itself, we virtually always use this to liberally accept more kinds of inputs.

[ghempton]

This turned out to be a another model cache issue in conjunction with a collection view. Sent a pull request with the fix and a test case.

[ghempton]

Fixed.