[BUGFIX release] restore internalModels GUID_KEY’s #4922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
referenced
this pull request
Apr 12, 2017
In future versions of Ember, the `Ember.GUID_KEY` property may not be the place that guids are stored per object (may be moving to a `WeakMap`). This change keeps `this[GUID_KEY]` around for easier debugging (though it isn't _required_ per-se), and uses `Ember.guidFor` to get the guid and setup the object.
stefanpenner
referenced
this pull request
Apr 12, 2017
- allocations are now lazy - InternalModel is now an ES2015 class, the expensive classCallCheck is stripped via a babel plugin - TransitionMapCache has been added to make transitionTo function faster - get/set of currentState has been moved to dot notation access - overall this appears to be a 20% perf improvement, with more gains still realizable.
stefanpenner
commented
Apr 12, 2017
| this._internalId = InternalModelReferenceId++; | ||
|
|
||
| // this ensure ordered set can quickly identify this as unique | ||
| this[Ember.GUID_KEY] = InternalModelReferenceId++ + 'internal-model'; |
There was a problem hiding this comment.
Was originally added as part of making stuff faster: ca9393f
Left a comment to hope it survives this time
There was a problem hiding this comment.
The comment will help this survive a lot better, the assumption before was that this shaping was to help the cases where internalModel was being abused by DS.Model (no longer is), meta, computeds and other public interface things.
There was a problem hiding this comment.
understood, the secret handshake this is doing is not obvious at all. Im not surprised it was lost.
stefanpenner
force-pushed
the
restore-guid-key
branch
from
42674ce
to
4dcb83d
Compare
bmac
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, adding an internalModel to an orderd set will result in a new [GUID_KEY] prop being added, but using defineProperty https://github.com/emberjs/ember.js/blob/master/packages/ember-utils/lib/guid.js#L187. Both causing a shape change, and a potentially costly defProp.
Restoring this restores that, and addresses a category of OrderdSet related performance issues.
@rwjblue / @runspired