[BUGFIX beta] Use native Map if present. #5255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
approved these changes
Nov 12, 2017
hjdivad
reviewed
Nov 14, 2017
| ``` | ||
| */ | ||
|
|
||
| export default class MapWithDefault { |
There was a problem hiding this comment.
Should we add copy and isEmpty to warn/error with a useful message for people who may be relying on this?
It seems unlikely, but on the other hand, MapWithDefault is returned by some public API
|
I'm going to try and pick this back up today/tomorrow to cleanup and address the points @hjdivad mentioned above... |
When native `Map` is present, use it. Otherwise fallback to `Ember.Map`. This positions ember-data for the eventual deprecation and dropping of `Ember.Map` and `Ember.MapWithDefault` in Ember itself (and using native classes should generally be better for us long term than shipping custom _slightly_ different versions). Note there are a few specific differences between native `Map` (and the `MapWithDefault` implementation that extends from the native `Map` when possible) and Ember's `Ember.Map` that we should be aware of: * `Ember.Map` has custom `copy` and `isEmpty` methods which are not present in native `Map` * `Ember.Map` adds a static `create` method (which simply instantiates itself with `new Ember.Map()`) * `Ember.Map` does not accept constructor arguments * `Ember.Map` does not have: * `@@species` * `@@iterator` * `entries` * `values`
rwjblue
changed the title
|
Thanks @rwjblue. |
bmac
pushed a commit
that referenced
this pull request
Mar 15, 2018
When native `Map` is present, use it. Otherwise fallback to `Ember.Map`. This positions ember-data for the eventual deprecation and dropping of `Ember.Map` and `Ember.MapWithDefault` in Ember itself (and using native classes should generally be better for us long term than shipping custom _slightly_ different versions). Note there are a few specific differences between native `Map` (and the `MapWithDefault` implementation that extends from the native `Map` when possible) and Ember's `Ember.Map` that we should be aware of: * `Ember.Map` has custom `copy` and `isEmpty` methods which are not present in native `Map` * `Ember.Map` adds a static `create` method (which simply instantiates itself with `new Ember.Map()`) * `Ember.Map` does not accept constructor arguments * `Ember.Map` does not have: * `@@species` * `@@iterator` * `entries` * `values` (cherry picked from commit f60d1e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When native
Mapis present, use it. Otherwise fallback toEmber.Map.This positions ember-data for the eventual deprecation and dropping of
Ember.MapandEmber.MapWithDefaultin Ember itself (and using native classes should generally be better for us long term than shipping custom slightly different versions).Note there are a few specific differences between native
Map(and theMapWithDefaultimplementation that extends from the nativeMapwhen possible) and Ember'sEmber.Mapthat we should be aware of:Ember.Maphas customcopyandisEmptymethods which are not present in nativeMapEmber.Mapadds a staticcreatemethod (which simply instantiates itself withnew Ember.Map())Ember.Mapdoes not accept constructor argumentsEmber.Mapdoes not have:@@species@@iteratorentriesvaluesAddresses
Ember.MapandEmber.MapWithDefaultusages from #5254.