[BUGFIX beta] Fix development build relationship caching. #5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmac
approved these changes
Jan 22, 2018
|
Much easier to review with: https://github.com/emberjs/data/pull/5332/files?w=1 |
runspired
approved these changes
Jan 22, 2018
runspired
requested changes
Jan 22, 2018
rwjblue
force-pushed
the
fix-relationship-caching
branch
4 times, most recently
from
27fcef2
to
cc0ee04
Compare
The previous implementation was intending to cache relationships when in the production environment, but avoid caching them in development. Unfortunately, this code was factored in a way that relied on mutating internal private state of the underlying `Ember.ComputedProperty` instance when `Ember.testing` was true (which was used as a way to determine prod vs non-prod). When this code was introduced (2014-12-02), setting `_cacheable` on a `ComputedProperty` instance would have worked as intended, however a refactor in Ember (ironically one day prior, but on Ember's canary channel) deprecated using `_cacheable` or `.cacheable()` (in favor of opting out of caching via `.volatile()`). Since this has not worked since Ember 2.0.0, and it has not been an issue, this commit completely removes the manual caching / volatile swapping between prod/dev/testing environments.
rwjblue
force-pushed
the
fix-relationship-caching
branch
from
cc0ee04
to
18a0534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was intending to cache relationships when in the production environment, but avoid caching them in development. Unfortunately, this code was factored in a way that relied on mutating internal private state of the underlying
Ember.ComputedPropertyinstance whenEmber.testingwas true (which was used as a way to determine prod vs non-prod).When this code was introduced (2014-12-02 in #2530), setting
_cacheableon aComputedPropertyinstance would have worked as intended, however a refactor in Ember (ironically one day prior in emberjs/ember.js#9489, but on Ember's canary channel) deprecated using_cacheableor.cacheable()(in favor of opting out of caching via.volatile()). Later support for_cacheablewas completely removed in emberjs/ember.js#12036 leading up to Ember 2.0.0.This PR refactors the code a bit, so that we no longer need to mutate the computed property after creation and allows us to avoid some gnarliness...