upgrade all the deps #144
Merged
upgrade all the deps #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
May 16, 2017
.travis.yml
Outdated
| - npm test | ||
| # Usually, it's ok to finish the test scenario without reverting | ||
| # to the addon's original dependency state, skipping "cleanup". | ||
| - node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO test --skip-cleanup |
There was a problem hiding this comment.
I believe this will result in us not actually running the node tests?
.travis.yml
Outdated
|
|
||
| env: | ||
| # we recommend testing LTS's and latest stable release (bonus points to beta/canary) | ||
| - EMBER_TRY_SCENARIO=ember-lts-2.4 |
There was a problem hiding this comment.
There is no ember specific code here, I don't think we need to test more than one (slowing down CI runs...)
.travis.yml
Outdated
| - "6" | ||
| - "7" |
There was a problem hiding this comment.
We need to continue to test against 4, 6, and 7.
|
@rwjblue thanks for the review, should be addressed now! |
rwjblue
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.