Deprecate Ember.Inflector, Ember.String.singularize() and Ember.String.pluralize() #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Jul 11, 2017
Turbo87
force-pushed
the
deprecate-globals
branch
from
9c12ee0
to
e08944e
Compare
|
@stefanpenner @fivetanley any comments? |
|
👍 |
|
@fsmanuel good point, will update that too |
|
We need to update ember-data to avoid the deprecation before landing this. |
This was referenced Aug 22, 2017
|
Ember Data should be updated, with a backport to release, according to linked PRs. Merge? |
|
Yes, this is ready to merge and release. I’ll try to do it in the AM... |
|
@rwjblue reminder, just in case you forgot :) |
delkopiso
added a commit
to alphasights/ember-graphql-adapter
that referenced
this pull request
Nov 29, 2017
We're using ember-inflector incorrectly in two [deprecated](emberjs/ember-inflector#131) ways: - via `Ember.Inflector` - via `Ember.String.singularize` and `Ember.String.pluralize` and `ember-inflector` is not even listed as a dependency. Solution - Declares `ember-inflector` as an explicit dependency. - Fixes usage of `singularize` and `pluralize`. - Fixes usage of `Ember.Inflector` as prescribed in the [ember guides](https://guides.emberjs.com/v2.16.0/models/customizing-adapters/#toc_pluralization-customization)
delkopiso
added a commit
to alphasights/ember-graphql-adapter
that referenced
this pull request
Nov 29, 2017
Problem We're using ember-inflector incorrectly in two [deprecated](emberjs/ember-inflector#131) ways: - via `Ember.Inflector` - via `Ember.String.singularize` and `Ember.String.pluralize` and `ember-inflector` is not even listed as a dependency. Solution - Declares `ember-inflector` as an explicit dependency. - Fixes usage of `singularize` and `pluralize`. - Fixes usage of `Ember.Inflector` as prescribed in the [ember guides](https://guides.emberjs.com/v2.16.0/models/customizing-adapters/#toc_pluralization-customization)
delkopiso
added a commit
to alphasights/ember-graphql-adapter
that referenced
this pull request
Nov 29, 2017
Problem We're using ember-inflector incorrectly in two [deprecated](emberjs/ember-inflector#131) ways: - via `Ember.Inflector` - via `Ember.String.singularize` and `Ember.String.pluralize` and `ember-inflector` is not even listed as a dependency. Solution - Declares `ember-inflector` as an explicit dependency. - Fixes usage of `singularize` and `pluralize`. - Fixes usage of `Ember.Inflector` as prescribed in the [ember guides](https://guides.emberjs.com/v2.16.0/models/customizing-adapters/#toc_pluralization-customization)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves parts of #125
/cc @rwjblue