Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeing failing tests on /tests route with Ember Inspector open #816

Closed
cafreeman opened this issue May 31, 2018 · 2 comments · Fixed by #855
Closed

Seeing failing tests on /tests route with Ember Inspector open #816

cafreeman opened this issue May 31, 2018 · 2 comments · Fixed by #855
Labels

Comments

@cafreeman
Copy link

When running the tests in an Ember app using the /tests route, I'm seeing tests fail as a result of Ember Inspector's getOwner function throwing an exception (specifically, this line).

After digging into the stack trace for a bit, it appears that one of Ember Inspector's initializers (this one) is falling over when the second test in the suite beings (so, presumably when application.reset is being called).

It almost seems like my application instance isn't even getting passed into the initializer, so that when Ember Inspector tries to call methods on it, it immediately fails.

Have you ever run into this before, or do you have any ideas about what might be causing this?

@cafreeman cafreeman changed the title Seeing failing tests on /tests route with Ember Inspector route Seeing failing tests on /tests route with Ember Inspector open May 31, 2018
@RobbieTheWagner
Copy link
Member

@cafreeman I can't say that I have had Inspector open while running tests before. It seems like application.__deprecatedInstance__ would be something we would want to get away from though, as it looks very private and deprecated.

@teddyzeenny @rwjblue any ideas on alternatives?

@backspace
Copy link

This is happening to me on Ember 3.2.2 in Chrome. It fails while the developer tools are open, I don’t even have to be looking at Ember Inspector specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants