Check for owner before calling isGlimmerTwo #846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwwagner90 I'd say what we've got in this PR is at least an improvement in the interim even we want to settle on different semantics longterm. I'd assumed that we always had an owner before this, so making us aware of the possible null (thanks for the code comments!) is a good thing. I vote |
for now.
|
It seems we used to have an owner during tests, but maybe not anymore? Perhaps something changed in Ember 3.1+? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #816
This stops the errors from happening, when there is no owner, because now we are checking if we have an owner before trying to use the owner.
I am not sure if this is the correct solution or if there is a way to actually get the real owner again here, rather than just doing nothing if it does not exist.
@teddyzeenny do we want to support running the inspector on
localhost:4200/testsanyway?