Only deepClone when without prototype extensions #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
changed the title
wycats
force-pushed
the
no-deep-clone
branch
2 times, most recently
from
d877766
to
9a20539
Compare
This adds a non-trivial amount of cost for each message (especially the complex ones like the view tree) that is not necessary in most apps.
wycats
force-pushed
the
no-deep-clone
branch
from
9a20539
to
50ac13b
Compare
RobbieTheWagner
approved these changes
Dec 18, 2019
rwjblue
reviewed
Dec 18, 2019
| let deepClone; | ||
|
|
||
| if (Ember.ENV.EXTEND_PROTOTYPES.Array) { | ||
| deepClone = function deepClone(item) { |
There was a problem hiding this comment.
Just wanted to confirm, this is so that we can send the cloned item through the postmessage right? I ask because I want to confirm that we don't actually need to worry about deepClone being used just to be able to mutate the value...
There was a problem hiding this comment.
Yes. As far as. I can tell this is related to structure cloning. It’s done as one of the last steps before passing to chrome’s postMessage.
rwjblue
approved these changes
Dec 18, 2019
|
Oops! Forgot to squash and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a non-trivial amount of cost for each message (especially the complex ones like the view tree) that is not necessary in most apps.
Split from #1088. I'll rebase that PR once this lands.