Fix deprecated window.postMessage overload #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves feature deprecation warning in Chrome Canary V53; legacy window.postMessage overload https://www.chromestatus.com/features/5719033043222528
|
Thanks! |
|
@evansims this doesn't seemed to be fixed. I'm currently running chrome Beta v54, ember-inspector v2.0.2, and ember v2.8.1 and I'm still seeing this error in the chrome console: |
|
@nerdybeast Hmm, that sounds like an entirely different issue from what this commit fixed. I've not encountered that one myself, sorry. Probably worth opening an issue if you haven't already. |
|
@evansims thanks for the response. I lied in my last comment, I was only on Ember v2.8.0 but after "actually" upgrading to 2.8.1 the inspector is working again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves feature deprecation warning in Chrome Canary V53; legacy window.postMessage overload https://www.chromestatus.com/features/5719033043222528