Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initializers affect component integration tests if there is an acceptance test #146

Closed
jelhan opened this issue Jan 29, 2016 · 1 comment

Comments

@jelhan
Copy link

jelhan commented Jan 29, 2016

If there is an acceptance test an initalizers and instance-initializers affects component integration tests. If not they won't. Inconsistent errors depending on test filters is the result. Really confusing...

Let my give an example: I have an initalizer to configure webshim polyfill. I have a component integration test which was affected by webshim. Tests passes running ember test -m "Integration | Component | webshim affected component" while failing on ember test (which also runs some acceptance tests).

Was even more confusing since tests passed in chrome (which has native support for the feature) but failed in phantomjs (which uses polyfill) but ember isn't responsible therefore. 😄

ember-cli: 1.13.13
ember-qunit: 0.4.16

Moved from ember-cli/ember-cli#5405 as suggested.

@Turbo87
Copy link
Member

Turbo87 commented Oct 14, 2017

The only possible solution that I see for this is starting a new browser instance for every single test, which is obviously very slow. Integration test should in general not rely on any initializers. You could use ember-exam to randomize the test order and detect issues like that.

@Turbo87 Turbo87 closed this as completed Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants