Ensure moduleForModel uses the correct store for subject.
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `container` was shared across each module (NOT each test) inside `this.subject()` and `this.store()`. This ensures that those callbacks grab the `container` for each test run (instead of using the closure scope variable).
rwjblue
added a commit
that referenced
this pull request
Mar 24, 2015
Ensure `moduleForModel` uses the correct store for `subject`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
containerwas shared across each module (NOT each test) insidethis.subject()andthis.store().This ensures that those callbacks grab the
containerfor each test run (instead of using the closure scope variable).Credit to @bmac for tracking down the cause, and providing a reliable test reproduction.