Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qunit to v2.5.1 #344

Merged
merged 2 commits into from
Mar 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"lerna-changelog": "^0.7.0",
"loader.js": "^4.2.3",
"prettier": "^1.7.4",
"qunit": "^2.5.0"
"qunit": "^2.5.1"
},
"engines": {
"node": "^4.5 || 6.* || >= 7.*"
Expand Down
4 changes: 3 additions & 1 deletion tests/helpers/events.js
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,9 @@ export function instrumentElement(element) {

KNOWN_EVENTS.forEach(type => {
element.addEventListener(type, e => {
assert.step(type);
if (!element.hasAttribute('data-skip-steps')) {
assert.step(type);
}
assert.ok(e instanceof Event, `${type} listener should receive a native event`);
});
});
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/dom/blur-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ module('DOM Helper: blur', function(hooks) {
});

test('rejects if selector is not found', async function(assert) {
elementWithFocus.setAttribute('data-skip-steps', true);

await setupContext(context);

assert.rejects(
Expand All @@ -72,6 +74,8 @@ module('DOM Helper: blur', function(hooks) {
});

test('bluring via selector without context set', function(assert) {
elementWithFocus.setAttribute('data-skip-steps', true);

assert.rejects(
blur(`#${elementWithFocus.id}`),
/Must setup rendering context before attempting to interact with elements/
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/dom/click-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ module('DOM Helper: click', function(hooks) {
});

hooks.afterEach(async function() {
element.setAttribute('data-skip-steps', true);

if (element) {
element.parentNode.removeChild(element);
}
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/dom/fill-in-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ module('DOM Helper: fillIn', function(hooks) {
});

hooks.afterEach(async function() {
element.setAttribute('data-skip-steps', true);

if (element) {
element.parentNode.removeChild(element);
}
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/dom/focus-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ module('DOM Helper: focus', function(hooks) {
});

hooks.afterEach(async function() {
element.setAttribute('data-skip-steps', true);

if (element) {
element.parentNode.removeChild(element);
}
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/dom/tap-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ module('DOM Helper: tap', function(hooks) {
});

hooks.afterEach(async function() {
element.setAttribute('data-skip-steps', true);

if (element) {
element.parentNode.removeChild(element);
}
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/dom/trigger-event-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ module('DOM Helper: triggerEvent', function(hooks) {
});

hooks.afterEach(async function() {
element.setAttribute('data-skip-steps', true);

if (element) {
element.parentNode.removeChild(element);
}
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/dom/trigger-key-event-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ module('DOM Helper: triggerKeyEvent', function(hooks) {
});

hooks.afterEach(async function() {
element.setAttribute('data-skip-steps', true);

if (element) {
element.parentNode.removeChild(element);
}
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6516,9 +6516,9 @@ quick-temp@^0.1.0, quick-temp@^0.1.2, quick-temp@^0.1.3, quick-temp@^0.1.5, quic
rimraf "^2.5.4"
underscore.string "~3.3.4"

qunit@^2.5.0:
version "2.5.0"
resolved "https://registry.yarnpkg.com/qunit/-/qunit-2.5.0.tgz#64cbe30a1193ef02edc5b278efcdf1d0bae96b22"
qunit@^2.5.1:
version "2.5.1"
resolved "https://registry.yarnpkg.com/qunit/-/qunit-2.5.1.tgz#739b0ea9595bbf508b0600d5af04dcb2ba2a74e5"
dependencies:
chokidar "1.7.0"
commander "2.12.2"
Expand Down