Update buildMouseEvent to use MouseEvent constructor if it is present #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Jun 19, 2018
| } catch (e) { | ||
| // left intentionally blank |
There was a problem hiding this comment.
Hmm, aren’t some errors valid here? E.g. when MouseEvent is present but you pass invalid options or something?
There was a problem hiding this comment.
maybe we could make a constant in module scope to track if `MouseEvent‘ is functional, then remove the try/catch inline?
There was a problem hiding this comment.
Was following the pattern from buildKeyboardEvent, but I agree that the solution where checking if MouseEvent exists is better
cibernox
reviewed
Jun 19, 2018
| @@ -1,5 +1,15 @@ | |||
| import { merge } from '@ember/polyfills'; | |||
|
|
|||
| // eslint-disable-next-line require-jsdoc | |||
| function checkMouseEventExistence() { | |||
| try { | |||
There was a problem hiding this comment.
Do you have an example of where else Memoization it is done in this repo? Or another example I can emulate?
There was a problem hiding this comment.
Something like:
const MOUSE_EVENT_CONSTRUCTOR = (() => {
try {
new MouseEvent(‘test’);
return true;
} catch(e) {
return false;
}
})();
rwjblue
approved these changes
Jun 20, 2018
|
Bump? |
cibernox
approved these changes
Jul 31, 2018
|
It looks good to me. /cc @rwjblue |
This was referenced Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #266 by using the
MouseEventconstructor inbuildMouseEventif it is present. Otherwise, it falls back to the existinginitMouseEventfunction for compatibility with IE 9/10