Ensure that triggerEvent can simulate a file input change event with an empty FileList
#674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Jun 29, 2019
|
What is up with the CI failures? I do not think that they were caused by my changes looking through the logs. |
|
The failures on canary were due to an upstream issue that is fixed (emberjs/ember.js#18168). I've restarted the failed tests... |
|
And looks like the CI failed with seg faults. This looks like a problem with the CI and not my code? |
|
Yeah, I do not believe they are related. |
rwjblue
changed the title
triggerEvent can simulate a file input change event with an empty FileList
|
Can I get the CI kicked off again? |
|
I'm trying to dig into the CI issues with canary Ember (important now since we will be rolling those to beta next week), the failures are definitely not related to your changes. |
|
Oh great! Thank you for the information! |
|
OK, I think CI is fixed now just rebased and updated this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #673