Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The option "preventDefault" for the helper "action" only works with literals. #12740

Closed
phcoliveira opened this issue Dec 21, 2015 · 2 comments
Closed

The option "preventDefault" for the helper "action" only works with literals. #12740

phcoliveira opened this issue Dec 21, 2015 · 2 comments

Comments

@phcoliveira
Copy link

The title is self-explanatory.
Here is a twiddle for it.
https://ember-twiddle.com/fdde0eefb2086cc1794e
@Serabe Serabe mentioned this issue Dec 30, 2015
Merged
@Serabe
Copy link
Member

Serabe commented Dec 30, 2015

👍 Thank you for the report!

@mixonic
Copy link
Sponsor Member

mixonic commented Dec 30, 2015

@phcoliveira Some examples in the description might have gotten this attention more quickly- just a protip for the future :-)

You are correct that only literals work. We should either raise a better error or support bound values per @Serabe's work in #12764.

Serabe added a commit to Serabe/ember.js that referenced this issue Dec 30, 2015
@Serabe
[BUGFIX beta] Read values of action helper parameters
fa585ec 
This change makes helper `action` `read` values when the action is executed
instead of just using the value. This worked as far as the value was not bound.

Fixes emberjs#12740
rwjblue pushed a commit that referenced this issue Jan 12, 2016
@Serabe @rwjblue
[BUGFIX beta] Read values of action helper parameters
3bcb4c2 
This change makes helper `action` `read` values when the action is executed
instead of just using the value. This worked as far as the value was not bound.

Fixes #12740

(cherry picked from commit fa585ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mixonic @Serabe @phcoliveira