[BUGFIX beta] Read values of action helper parameters
#12764
Conversation
| @@ -1002,6 +1085,29 @@ QUnit.test('should respect preventDefault=false option if provided', function() | |||
| equal(event.isDefaultPrevented(), false, 'should not preventDefault'); | |||
| }); | |||
|
|
|||
| QUnit.test('should respect preventDefault=false option if provided bound', function() { | |||
| view = EmberView.create({ | |||
There was a problem hiding this comment.
I believe you can use an Ember.Component here and set the targetObject to be the controller. I am wary of adding new tests that use EmberView directly.
There was a problem hiding this comment.
I think I agreed on meeting @rwjblue after 2.3 was released to plan moving tests away from Ember.View. While new tests suites are easy to start with Ember.Component, most test files using views have already their setup and teardown based on that.
I rather write this with Ember.View and start working on a plan to migrate tests one complete file at a time.
There was a problem hiding this comment.
I agree with both here. 😺
Lets land to match the tests in the surrounding area, and then work to actually fix the test suite.
|
@Serabe if we add support for |
This change makes helper `action` `read` values when the action is executed instead of just using the value. This worked as far as the value was not bound. Fixes emberjs#12740
|
Added! |
[BUGFIX beta] Read values of `action` helper parameters
|
Thank you @Serabe! |
This change makes helper
actionreadvalues when the action is executedinstead of just using the value. This worked as far as the value was not bound.
Fixes #12740