Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC Release] Mark Enumerable.findBy as public #11612

Merged
merged 1 commit into from
Jul 8, 2015

Conversation

HeroicEric
Copy link
Sponsor Member

I think this might have been accidentally marked as private

@sly7-7
Copy link
Contributor

sly7-7 commented Jul 3, 2015

@HeroicEric Actually the entire enumerable has been marked as private during #11362
@rwjblue Is there something planned for enumerable to be deprecated, removed or something else ?
Maybe this is related to #11451 ?

@stefanpenner
Copy link
Member

confusingly we may actually support both private Enumerable, but public methods. The methods should reside on Array but its somewhat complicated....

We should likely move the docs to @for Ember.Array or something.

stefanpenner added a commit that referenced this pull request Jul 8, 2015
[DOC Release] Mark Enumerable.findBy as public
@stefanpenner stefanpenner merged commit 723a82e into emberjs:master Jul 8, 2015
@HeroicEric HeroicEric deleted the mark-find-by-public branch July 13, 2015 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants