[BUGFIX release] On re-render, ensure child views of non-dirty components get the correct parentView

[jder]

This is quite possibly a bad hack rather than a nice solution. I'd love suggestions for a cleaner approach.

On re-render of a non-dirty component, the env was simply passed down when
rendering the component's template, which means its parentView was wrong; this
patch mimics what keywords already do to solve this for components.

Fixes #11554

[stefanpenner]

rerunning tests

[stefanpenner]

@tomdale would love for your eyes on this.

[rwjblue]

Agreed. Would definitely like @tomdale or @wycats review.

[tomdale]

This actually seems like a totally legit use case for the buildChildEnv hook to me—cases where you need to fixup the child env but your render node may not be dirty.

[rwjblue]

@tomdale - So you are 👍?

[tomdale]

It's extremely reminiscent of the issue with outlets but admittedly I am a little out-of-context at the moment.

I have not carefully investigated but I can see why there could be an issue here. I'm comfortable with the fix if the test passed and no other tests regress.

[jder]

Thanks, all. Is there anything more I should do to get this into 2.0 as well, or does stable get merged into master regularly?

[mixonic]

@jder [BUGFIX release] goes into the current release (1.13.x) as well as beta and master. You can see contributing to Ember.js for more details about how commit tagging works.

[jder]

Ah! I made this to stable rather than master. (cc @rwjblue; this should apply to both master and stable) I had found the contributing doc in the repo, but not in the guide, sorry!

[rwjblue]

@jder - No worries, I'll pull it into beta and master branches now.