WIP: [CLEANUP beta] Drop legacy helper APIs, some legacy Handlebars usage #11858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amespace Drop: * Bare function helpers (legacy handlebars compat) * View helpers * makeBoundHelper
|
#11900 adds deprecations for all of these older helper styles, in preparation for this PR removing them... |
|
Needs work to be mergeable. I'd like to land this before 2.0.0-beta.5 (so that folks have a chance to digest with one last beta before final 2.0.0). I know that you are fighting with local build issues (I'm sorry), please let me know if you think this is in jeopardy of not being ready in the next day or two and I can try to pick it up... |
|
replaced by #11965 |
Eric-Guo
added a commit
to Eric-Guo/ember-examples-with-cli
that referenced
this pull request
Aug 7, 2015
Eric-Guo
added a commit
to Eric-Guo/ember-examples-with-cli
that referenced
this pull request
Aug 7, 2015
Eric-Guo
added a commit
to Eric-Guo/ember-examples-with-cli
that referenced
this pull request
Aug 9, 2015
Eric-Guo
added a commit
to Eric-Guo/ember-examples-with-cli
that referenced
this pull request
Aug 11, 2015
Eric-Guo
added a commit
to Eric-Guo/ember-examples-with-cli
that referenced
this pull request
Aug 13, 2015
Eric-Guo
added a commit
to Eric-Guo/ember-examples-with-cli
that referenced
this pull request
Aug 14, 2015
Eric-Guo
added a commit
to Eric-Guo/ember-examples-with-cli
that referenced
this pull request
Aug 21, 2015
Eric-Guo
added a commit
to Eric-Guo/ember-examples-with-cli
that referenced
this pull request
Aug 23, 2015
Eric-Guo
added a commit
to Eric-Guo/ember-examples-with-cli
that referenced
this pull request
Sep 12, 2015
Eric-Guo
added a commit
to Eric-Guo/ember-examples-with-cli
that referenced
this pull request
Sep 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.0 we drop:
Ember.Handlebars.makeViewHelper,Ember.HTMLBars.makeViewHelper)Ember.Handlebars.makeBoundHelper)Ember.Handlebars.registerHelperEmber.HTMLBars._registerHelperThis PR is very much WIP (my setup is whack), but I wanted to get it out there in case any one else was looking at this part of the 2.0 changes.
This requires and audit of deprecations messages in 1.13 to ensure everything is properly deprecated.