New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jQuery versions 1.12 and 2.2 #12787

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@thijsvdanker
Copy link

thijsvdanker commented Jan 8, 2016

The 1.12.0 and 2.2.0 release of jQuery have been tagged a couple of hours ago.
The regex for checking jQuery versions for Ember Views didn't pass for 1.12.x or 2.2.x

@thijsvdanker thijsvdanker changed the title Changed regex for jQuery version to allow for 1.12 Support jQuery versions 1.12 and 2.2 Jan 8, 2016

@blimmer

This comment has been minimized.

Copy link

blimmer commented Jan 8, 2016

👍 this just started causing me problems, too. Should we consider locking the version down in ember-cli bower.json blueprint ? If we don't do that 1.13.x of jQuery will cause this same problem.

@stefanpenner

This comment has been minimized.

Copy link
Member

stefanpenner commented Jan 8, 2016

embers test suite needs to also run against this (and pass) before we will consider merge.

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Jan 8, 2016

@thijsvdanker

This comment has been minimized.

Copy link

thijsvdanker commented Jan 8, 2016

When running TEST_SUITE=all npm test locally I get

Error: Could not find module ember-dev/test-helper/index


  http://localhost:13141/ember-template-compiler.js:58 in missingModule
  http://localhost:13141/ember-template-compiler.js:80 in internalRequire
  http://localhost:13141/ember-template-compiler.js:44 in requireModule
  http://localhost:13141/tests/?skipPackage=container,ember-testing,ember-debug&dist=min&prod=true:135


Test failed: global failure

    Failed assertion: Error: Could not find module ember-dev/test-helper/index
http://localhost:13141/ember-template-compiler.js:58


Took 8ms to run 1 tests. 0 passed, 1 failed.

Failed!
npm ERR! Test failed.  See above for more details.
@thijsvdanker

This comment has been minimized.

Copy link

thijsvdanker commented Jan 8, 2016

But I'm getting the same error when running it with jQuery 1.11.3 so this might error not be related to this PR.

@thijsvdanker

This comment has been minimized.

Copy link

thijsvdanker commented Jan 8, 2016

I am also getting that error when testing the master branch and the release-2-1 branch so that's something in my environment.

Not really sure how to push forward on this one.

@thijsvdanker

This comment has been minimized.

Copy link

thijsvdanker commented Jan 8, 2016

They've just made a blog post about the new releases, maybe the changelogs helps someone in pin-pointing this issue?
http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/

@lordpixel

This comment has been minimized.

Copy link

lordpixel commented Jan 9, 2016

In my case I'm getting the following errors:

Uncaught Error: Assertion Failed: Ember Views require jQuery between 1.7 and 2.1
Uncaught Error: Could not find module ember imported from x/app

As a temporary solution I did:

  • Remove the ^ from my jQuery dependency in bower.js (is now "jquery": "1.11.3")
  • Remove bower_components folder
  • Perform a bower install

I hope this serves as a temporary remedy while we Ember's team provides a definitive solution.

Thank you!

@ryanhollister

This comment has been minimized.

Copy link

ryanhollister commented Jan 9, 2016

Can I ask the hypothetical question of, "What if the assert is just removed?". Bower and NPM seem better suited to manage/resolve dependencies. People manually managing dependencies management will just have to read the documentation if there comes a time ember is not compatible with a new version of jquery.

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Jan 9, 2016

I would like to see one of these two things happen:

  • Remove the assertion completely.
  • Change the assertion to match minimum supported jQuery version. This would address the original issue that caused us to add the assertion in the first place.

I would prefer to simply remove the assertion...

@alexspeller

This comment has been minimized.

Copy link
Contributor

alexspeller commented Jan 9, 2016

👍 on removing the assertion, it seems like it's a bit of a hangover from before the ember-cli world, I believe in any case using ember outside of ember-cli when bower is controlling versions is an advanced usecase anyway so the assertion is less useful

@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Jan 9, 2016

#12793 removes the assertion

@blimmer

This comment has been minimized.

Copy link

blimmer commented Jan 9, 2016

@thijsvdanker @rwjblue I just bumped to jQuery 1.12 and ran the Ember test suite locally without failures.

@stefanpenner

This comment has been minimized.

Copy link
Member

stefanpenner commented Jan 9, 2016

@homu

This comment has been minimized.

Copy link
Contributor

homu commented Jan 9, 2016

☔️ The latest upstream changes (presumably #12793) made this pull request unmergeable. Please resolve the merge conflicts.

@matthewphilyaw matthewphilyaw referenced this pull request Jan 10, 2016

Merged

added ember js, still early. #14

5 of 5 tasks complete

GUI added a commit to GUI/ember-easyForm that referenced this pull request Jan 11, 2016

Fix ember test hanging due to jQuery 1.12 release.
Pinning to 1.11.3 since Ember doesn't yet run under jQuery 1.12.

See ember-cli/ember-cli#5317 and
emberjs/ember.js#12787

jelhan added a commit to jelhan/ember-form-master-2000 that referenced this pull request Jan 16, 2016

g-cassie added a commit to g-cassie/ember-form-master-2000 that referenced this pull request Jan 18, 2016

ryanto added a commit to ryanto/ember-page-object that referenced this pull request Feb 23, 2016

Upgrade ember suave, pin jquery
I just pulled this project and was unable to get tests running. Applying
the follow gets all tests passing.

Upgrade ember-suave to 1.2.3
DavyJonesLocker/ember-suave#84

jQuery version pin
emberjs/ember.js#12787

@dahlbyk dahlbyk referenced this pull request Mar 16, 2016

Merged

Bump SaaS Rails to 4.2.4 #237

sukima added a commit to sukima/ember-cli-select-picker that referenced this pull request Apr 1, 2016

Fix failing tests
The Ember 1.13 test (default) crashed because of the jQuery 1.12 upgrade
bug (emberjs/ember.js#12787)

The beta and canary tests failed because I forgot to remove them from
the travis config in commit ce1df21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment