-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic ember-cli addon structure #13000
Conversation
This will cause the dev dependencies to be installed even though they are not necessarily needed
... and add a very basic index.js file
Looks good. @rwjblue: is there a basic sanity test we could add? |
@mmun I don't think there is anything we can test at this point, but once we start testing the blueprints this should be included in the tests. |
@stefanpenner @mmun and I discussed this on Slack and came to the conclusion that it would be easiest to start fresh and pull the useful bits from #12412 over one-by-one. As mentioned above I think it would be a good idea to first make this project an addon (this PR) and then use separate PRs for the tasks listed above (blueprints, shims, ...). |
@Turbo87 ya likely, as the blueprints and stuff are not out of sync. If you need me to doit, let me know. Now that we are further along with other extractions (that i discovered were required while working on that PR), it should be relatively not horrible to redo. |
@stefanpenner as the blueprint stuff seems relatively straight forward I'd appreciate it if you could tackle the "add necessary Ember.js files to the broccoli trees" point. this seems to have been worked on in #12412 but I'm not sure if was finished (and how it actually works). |
Ya I can add that |
@stefanpenner cool, thanks! how do we proceed in getting this PR merged in the meantime? can you r+ or do we need more reviews/opinions first? |
Add basic ember-cli addon structure
🎉 Gracias! |
This PR adds the base structure for
ember-cli
to recognize this project as an addon and continues the work started in #12412.This PR only adds the base structure, more advanced things should IMHO be done in unrelated PRs and can be done in parallel once this one is merged:
ember-cli
(see Import blueprints fromember-cli
#13029)ember-cli-shims
(see provide ember-core from NPM #13022)/cc @mmun @stefanpenner