Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic ember-cli addon structure #13000

Merged
merged 2 commits into from
Feb 25, 2016
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 23, 2016

This PR adds the base structure for ember-cli to recognize this project as an addon and continues the work started in #12412.

This PR only adds the base structure, more advanced things should IMHO be done in unrelated PRs and can be done in parallel once this one is merged:

/cc @mmun @stefanpenner

This will cause the dev dependencies to be installed even though they are not necessarily needed
... and add a very basic index.js file
@mmun
Copy link
Member

mmun commented Feb 23, 2016

Looks good.

@rwjblue: is there a basic sanity test we could add?

@Turbo87
Copy link
Member Author

Turbo87 commented Feb 24, 2016

@mmun I don't think there is anything we can test at this point, but once we start testing the blueprints this should be included in the tests.

see Turbo87/ember.js@6c48a46...0edf21c

@stefanpenner
Copy link
Member

@Turbo87 would you like me to rebase #12412 and submit it as a PR this this branch? (I am flying today, but can likely doit once i arrive home)

@stefanpenner
Copy link
Member

Oh, its worth noting on of the remaining pieces that prevented #12412 from landing was also extracting the tests, now that @trabus has extracted us some lovely test helpers, we should be in a much better place.

@Turbo87
Copy link
Member Author

Turbo87 commented Feb 24, 2016

@stefanpenner @mmun and I discussed this on Slack and came to the conclusion that it would be easiest to start fresh and pull the useful bits from #12412 over one-by-one. As mentioned above I think it would be a good idea to first make this project an addon (this PR) and then use separate PRs for the tasks listed above (blueprints, shims, ...).

@stefanpenner
Copy link
Member

@Turbo87 ya likely, as the blueprints and stuff are not out of sync.

If you need me to doit, let me know. Now that we are further along with other extractions (that i discovered were required while working on that PR), it should be relatively not horrible to redo.

@Turbo87
Copy link
Member Author

Turbo87 commented Feb 24, 2016

@stefanpenner as the blueprint stuff seems relatively straight forward I'd appreciate it if you could tackle the "add necessary Ember.js files to the broccoli trees" point. this seems to have been worked on in #12412 but I'm not sure if was finished (and how it actually works).

@stefanpenner
Copy link
Member

Ya I can add that

@Turbo87
Copy link
Member Author

Turbo87 commented Feb 25, 2016

@stefanpenner cool, thanks!

how do we proceed in getting this PR merged in the meantime? can you r+ or do we need more reviews/opinions first?

stefanpenner added a commit that referenced this pull request Feb 25, 2016
Add basic ember-cli addon structure
@stefanpenner stefanpenner merged commit c152e3f into emberjs:master Feb 25, 2016
@Turbo87
Copy link
Member Author

Turbo87 commented Feb 25, 2016

🎉 Gracias!

@Turbo87 Turbo87 deleted the addon branch February 26, 2016 11:32
@Turbo87 Turbo87 mentioned this pull request Mar 4, 2016
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants