[BUGFIX beta] Update Registry#has to always return true/false. #13356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -692,9 +694,13 @@ Registry.prototype = { | |||
| return assign({}, fallbackKnown, localKnown, resolverKnown); | |||
| }, | |||
|
|
|||
| validateFullName(fullName) { | |||
| validateFullName(fullName, tolerant) { | |||
There was a problem hiding this comment.
How about this alternative:
- Create a new method
isValidFullNamethat returns a boolean and never throws. validateFullNamecould internally callisValidFullName, as couldhas.validateFullNamecould continue to throw.
I think this works because validateFullName sounds imperative and I would expect it to throw, plus the tolerant param seems a bit iffy.
There was a problem hiding this comment.
OK, just updated. Thanks again, this is a much better pattern.
|
Looks a lot better to me. Thanks @rwjblue 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12082.