[WIP] Refactor Meta's deps structure to an array of arrays. #13659
Conversation
|
@krisselden - I updated this to use an array of arrays (instead of a map of arrays). I left it in two commits so that it was easy to compare the difference (in case you end up liking the map of arrays approach better). The best summary of the new structure is from // add the subkey to the outerArray
keyArray.push([
subkey,
// array of itemKeys for the subkey
[
[itemKey, value]
]
]); |
rwjblue
changed the title
|
this used to be 5.4 http://numberofpeoplewhounderstandembermetal.com/ |
| let innerMap = outerMap[subkey]; | ||
| if (!innerMap) { | ||
| innerMap = outerMap[subkey] = new EmptyObject(); | ||
| Meta.prototype['write' + capitalized] = function(subkey, itemKey, value) { |
There was a problem hiding this comment.
Nit: Can you do write${capitalized}, same goes for the other dynamic method. 😄
|
Updated #13660 to migrate to using the lodash-like object interface for this functionality. Closing this in favor of that. @chadhietala - I'll make sure to incorporate your comments there though... |
|
☔ The latest upstream changes (presumably #13783) made this pull request unmergeable. Please resolve the merge conflicts. |
/cc @krisselden @ef4