[Glimmer2] tests for html-safe and render #13845
Conversation
|
@chadhietala - This is good to me. Can you make https://github.com/emberjs/ember.js/blob/master/packages/ember-htmlbars/lib/utils/string.js a symlink to the |
| @@ -0,0 +1 @@ | |||
| ../../../ember-htmlbars/lib/utils/string.js | |||
There was a problem hiding this comment.
I think this should go the other way since in the long term we are going to rm -rf packages/ember-htmlbars.
|
Overall this look good (one comment/tweak), can you confirm that |
|
What I ended up doing is moving the string module into |
| Ember.HTMLBars = { SafeString }; | ||
| } | ||
|
|
||
| if (Ember.HandlerBars) { |
There was a problem hiding this comment.
Should be Ember.Handlebars (a few places below are typo'ed too).
There was a problem hiding this comment.
Can you also move these Ember.Handlebars exports to ember-templates/compat?
chadhietala
changed the title
|
Had to do some reorg and deletion of some similar work. Also moved the action test to #13850. |
| EmberHTMLBars.template = EmberHandlebars.template = template; | ||
| EmberHTMLBarsUtils.escapeExpression = EmberHandleBarsUtils.escapeExpression = escapeExpression; |
There was a problem hiding this comment.
I do not believe that we ever exposed this previously on Ember.HTMLBars, can you confirm and if we haven't fixup?
Maintain our own safestring and escapeexpression for now
|
LGTM |
/cc @krisselden @rwjblue
Pretty sure we want to just use the SafeString from HandleBars, however it is unclear how we should import it sense it was a proxy import in HTMLBars.