Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pave the way for shipping only glimmer engine. #13849

Merged
merged 1 commit into from Jul 23, 2016

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jul 20, 2016

Update build system to allow excluding ember-htmlbars and its dependencies if ember-glimmer feature flag is true.

@homu
Copy link
Contributor

homu commented Jul 20, 2016

☔ The latest upstream changes (presumably #13845) made this pull request unmergeable. Please resolve the merge conflicts.

Many errors still exist, but this paves the way to start fixing any
imports from `ember-htmlbars` in the rest of the codebase.
@rwjblue
Copy link
Member Author

rwjblue commented Jul 23, 2016

OK, I have removed all the extraneous changes from this PR. Now this only contains the packaging changes required to make this work.

It is still not possible to remove ember-htmlbars (by changing ember-glimmer flag to true in features.json), but we will continue chipping away at the failures in separate more focused PR's.

@rwjblue rwjblue merged commit 7544739 into emberjs:master Jul 23, 2016
@rwjblue rwjblue deleted the htmlbars-less branch July 23, 2016 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants