Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] render in the rendering queue #14517

Merged
merged 1 commit into from
Oct 26, 2016
Merged

[BUGFIX beta] render in the rendering queue #14517

merged 1 commit into from
Oct 26, 2016

Conversation

stefanpenner
Copy link
Member

@stefanpenner stefanpenner commented Oct 25, 2016 •
edited
Loading

  • ensure appendOutletView is scheduled
  • remove unused functions (rerender, destroy)
  • tests
  • confirm this is in the right place

@stefanpenner stefanpenner mentioned this pull request Oct 25, 2016
Closed
@stefanpenner stefanpenner force-pushed the render-in-render-queue branch 4 times, most recently from 798d17b to d79d872 Compare October 26, 2016 01:23
@stefanpenner
[BUGFIX beta] render in the rendering queue
2e4d981 
* [FIXES #14516]
* ensure appendOutletView is scheduled
* remove unused functions (rerender, destroy)
@stefanpenner
Copy link
Member Author

@krisselden r?

rwjblue
rwjblue approved these changes Oct 26, 2016
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanpenner stefanpenner merged commit 9d35d9c into master Oct 26, 2016
@stefanpenner stefanpenner deleted the render-in-render-queue branch October 26, 2016 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanpenner @rwjblue