Remove internal factoryInjection API #14816
Conversation
locks
commented
Jan 11, 2017
•
locks
commented
- Container: A factory returned from lookupFactory has a debugkey
- Ember.Application Dependency Injection – toString: instances
- Ember.Application Dependency Injection – toString: with a custom resolver
locks
force-pushed
the
skull-emoji-factory-injection
branch
from
9e40ee1
to
7041640
Compare
Remove factoryInjections related code Kill lookupFactory debugkey test Add NAME_KEY to injectedFactory class
locks
force-pushed
the
skull-emoji-factory-injection
branch
from
275739b
to
d69f8d3
Compare
packages/container/lib/container.js
Outdated
|
|
||
| let injectedFactory = factory.extend(injections); | ||
|
|
||
| // TODO - remove all `container` injections when Ember reaches v3.0.0 | ||
| injectDeprecatedContainer(injectedFactory.prototype, container); | ||
| injectedFactory.reopenClass(factoryInjections); | ||
| injectedFactory.reopenClass({ [NAME_KEY]: registry.makeToString(factory, fullName) }); |
There was a problem hiding this comment.
Ideally we can get rid of this also (I'm not sure we have solved the "problem" of factory injections if we cannot remove this reopenClass).
|
☔ The latest upstream changes (presumably #15014) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@locks ping |
|
@stefanpenner there was a problem with 5b2dc4d that I don't know how to address. I think it particularly broke some of Ember Data's output. |
|
☔ The latest upstream changes (presumably #15177) made this pull request unmergeable. Please resolve the merge conflicts. |
@locks can you enumerate the problem, steps to reproduce? |
|
I believe this will be replaced by #15193. |
