Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _lookupFactory support. #15193

Merged
merged 3 commits into from May 1, 2017
Merged

Remove _lookupFactory support. #15193

merged 3 commits into from May 1, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 30, 2017

This was deprecated in Ember 2.12 (which was an LTS version).

This removes owner._lookupFactory APIs completely. It also includes
factory injections, and factory type injections.

@rwjblue
Copy link
Member Author

rwjblue commented Apr 30, 2017

This is in a similar area but independent of #15192.

This was referenced Apr 30, 2017
Merged
Closed
@rwjblue
Copy link
Member Author

rwjblue commented Apr 30, 2017

Please note that there is one commit that is actually a BUGFIX beta (but may need to be BUGFIX lts). It turns out that we did not validate things like Ember.inject.service when owner.factoryFor was used (this is because we were only invoking _onLookup in the lookupFactory path.

@rwjblue rwjblue force-pushed the remove-lookup-factory branch 2 times, most recently from 42bdfa1 to c6cd7c6 Compare April 30, 2017 20:40
@stefanpenner
Copy link
Member

@rwjblue thanks for the cleanup!

@homu
Copy link
Contributor

homu commented May 1, 2017

☔ The latest upstream changes (presumably #15192) made this pull request unmergeable. Please resolve the merge conflicts.

@rwjblue rwjblue merged commit 85cd220 into emberjs:master May 1, 2017
@rwjblue rwjblue deleted the remove-lookup-factory branch May 1, 2017 18:13
@homu homu mentioned this pull request May 1, 2017
Closed
@rwjblue rwjblue mentioned this pull request May 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanpenner stefanpenner stefanpenner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rwjblue @stefanpenner @homu