Start removing implicit any errors #15773
Conversation
| @@ -0,0 +1,17 @@ | |||
| interface Container { | |||
There was a problem hiding this comment.
I stubbed out a more limited interface for this in ember-glimmer we should unify
| return vm.getSelf().get('ariaRole'); | ||
| } | ||
|
|
||
| class CurlyComponentLayoutCompiler { | ||
| static id: string; | ||
| public template: any; | ||
|
|
||
| constructor(template) { | ||
| constructor(template: any) { |
There was a problem hiding this comment.
I did make a type for template
| // tslint:disable-next-line:no-shadowed-variable | ||
| let { tagName } = vm.dynamicScope().view; | ||
|
|
||
| return PrimitiveReference.create(tagName === '' ? null : tagName || 'div'); | ||
| } | ||
|
|
||
| function ariaRole(vm) { | ||
| function ariaRole(vm: any) { |
There was a problem hiding this comment.
there is a type exported for this, I think it is called PublicVM
There was a problem hiding this comment.
Works for the ariaRole function, but not tagName: Property 'view' does not exist on type 'DynamicScope'
| } | ||
|
|
||
| get(key) { | ||
| get(key: any) { |
| } | ||
| return env.getCompiledBlock(CurlyComponentLayoutCompiler, template); | ||
| } | ||
|
|
||
| templateFor(component, env) { | ||
| templateFor(component: ComponentStateBucket, env: Environment): any { | ||
| let Template = get(component, 'layout'); |
There was a problem hiding this comment.
we have a type for what templates return look at the template .d.ts I updated
| export const HashLocation: any; | ||
| export const HistoryLocation: any; | ||
| export const AutoLocation: any; | ||
|
|
There was a problem hiding this comment.
lets at least type the signature of the functions
rwjblue
force-pushed
the
typed-ember-glimmer
branch
from
a253b69
to
29689a3
Compare
Thusfar: component-managers/abstract.ts (2 errors remain) component-managers/curly.ts (some errors remain) component-managers/mount.ts utils/curly-component-state-bucket.ts
There are a few uses of `any` still, and a few errors I'm still trying to figure out.
Tests are broken due at the moment. CurlyComponentManager's templateFor is where the problems begin. Fix will come in next commit.
|
Despite the green check, I don't think this is ready yet. There are several TypeScript errors still. |
|
@smfoote - Sounds good, let us know when you think it is ready for another round of review and possible merging. |
|
Since the checks are passing, we might merge this one as is then fix the remaining TypeScript errors in a future PR. I'll leave that up to @krisselden |
Thusfar:
component-managers/abstract.ts (2 errors remain)
component-managers/curly.ts (some errors remain)
component-managers/mount.ts
utils/curly-component-state-bucket.ts