Upgrade glimmer-vm to latest #15828
Merged
Upgrade glimmer-vm to latest #15828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is much left to do here. This is just the first pass, where I have done nothing but try to clear out the errors caused by the upgrade. Not all of the errors are cleared yet, largely because several exports from glimmer-vm have been removed and I don't know how to replace them (help wanted). Below is a list of the needed changes and problems I have encountered in the upgrade process. UPGRADE NOTES (starting at glimmer-vm 0.25.6) * Simple is now in @glimmer/interfaces * ComponentManager.getSelf cannot return null (returns RootReference?) * ComponentManager.getTag returns ComponentStateBucket.tag (: Tag) * Some code moved from ComponentManager.update to * ComponentManager.didUpdate * ComponentManager<ComponentStateBucket> --> * ComponentManager<ComponentStateBucket, ComponentDefinition> * ComponentManager.create signature changed * ComponentStateBucket's defintion is now DefinitionState instead of * ComponentDefinition * ComponentManager.prepareArgs signature changed * ComponentManager.getCapabilities is new * CompiledDynamicTemplate is gone (no longer in runtime, anyway) see * glimmerjs/glimmer-vm@79f2b45#diff-d561208b0ad153d9273c2188e16c7442 * Must implicitly include @glimmer/vm and @glimmer/opcode-compiler and * @glimmer/encoder in ember-cli-build.js * compileLayout -> scanLayout -> prepareLayout -> new WrappedBuilder * isSafeString is no longer exported publicly. Is that intentional? * normalizeTextValue is no longer exported publicly. Is that * intentional? * isComponentDefinition is gone, kind of replaced by * `isCurriedComponentDefinition`. Neither is exported. * getComponentDefintion is no longer part of Environment. * referenceFromParts has been removed. * f3444e9ae0c7751047bdcd856e61344bfb548e12 * readDOMAttr has been removed. 316805b9175e01698120b9566ec51c88d075026a
The contents are not rendering at all, and a lot of the code is not handling error cases. This is just to get the component to render at all.
|
GREEEEEEEEEEEEEEEEEEEEEEEEENNNNNNNNNN!!!!! |
End users of `ember-source` do not need these dependencies...
rwjblue
changed the title
this is due to the Proxy issue
rwjblue
force-pushed
the
upgrade-glimmer
branch
from
1ead760
to
eeecb9b
Compare
|
@rwjblue what does this mean for ember users? |
|
Not much. Just a dependency update. 😃 |
|
@rwjblue does this update unblock rehydration for server-sider rendered apps? |
|
@SergeAstapov there was some initial discussion of this on the Fastboot Slack channel. Because yes, folks are interested in exploring that now ... 😀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (help
wanted). Below is a list of the needed changes and problems I have
encountered in the upgrade process.
UPGRADE NOTES (starting at glimmer-vm 0.25.6)
isCurriedComponentDefinition. Neither is exported.