Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade glimmer-vm to latest #15828

Merged
merged 148 commits into from
Jan 26, 2018
Merged

Upgrade glimmer-vm to latest #15828

merged 148 commits into from
Jan 26, 2018

Conversation

smfoote
Copy link
Contributor

@smfoote smfoote commented Nov 6, 2017

There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (help
wanted). Below is a list of the needed changes and problems I have
encountered in the upgrade process.

UPGRADE NOTES (starting at glimmer-vm 0.25.6)

  • Simple is now in @glimmer/interfaces
  • ComponentManager.getSelf cannot return null (returns RootReference?)
  • ComponentManager.getTag returns ComponentStateBucket.tag (: Tag)
  • Some code moved from ComponentManager.update to
  • ComponentManager.didUpdate
  • ComponentManager -->
  • ComponentManager<ComponentStateBucket, ComponentDefinition>
  • ComponentManager.create signature changed
  • ComponentStateBucket's defintion is now DefinitionState instead of
  • ComponentDefinition
  • ComponentManager.prepareArgs signature changed
  • ComponentManager.getCapabilities is new
  • CompiledDynamicTemplate is gone (no longer in runtime, anyway) see
  • glimmerjs/glimmer-vm@79f2b45#diff-d561208b0ad153d9273c2188e16c7442
  • Must implicitly include @glimmer/vm and @glimmer/opcode-compiler and
  • @glimmer/encoder in ember-cli-build.js
  • compileLayout -> scanLayout -> prepareLayout -> new WrappedBuilder
  • isSafeString is no longer exported publicly. Is that intentional?
  • normalizeTextValue is no longer exported publicly. Is that
  • intentional?
  • isComponentDefinition is gone, kind of replaced by
  • isCurriedComponentDefinition. Neither is exported.
  • getComponentDefintion is no longer part of Environment.
  • referenceFromParts has been removed.
  • f3444e9ae0c7751047bdcd856e61344bfb548e12
  • readDOMAttr has been removed. 316805b9175e01698120b9566ec51c88d075026a

There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (help
wanted). Below is a list of the needed changes and problems I have
encountered in the upgrade process.

UPGRADE NOTES (starting at glimmer-vm 0.25.6)

* Simple is now in @glimmer/interfaces
* ComponentManager.getSelf cannot return null (returns RootReference?)
* ComponentManager.getTag returns ComponentStateBucket.tag (: Tag)
* Some code moved from ComponentManager.update to
* ComponentManager.didUpdate
* ComponentManager<ComponentStateBucket> -->
* ComponentManager<ComponentStateBucket, ComponentDefinition>
* ComponentManager.create signature changed
* ComponentStateBucket's defintion is now DefinitionState instead of
* ComponentDefinition
* ComponentManager.prepareArgs signature changed
* ComponentManager.getCapabilities is new
* CompiledDynamicTemplate is gone (no longer in runtime, anyway) see
* glimmerjs/glimmer-vm@79f2b45#diff-d561208b0ad153d9273c2188e16c7442
* Must implicitly include @glimmer/vm and @glimmer/opcode-compiler and
* @glimmer/encoder in ember-cli-build.js
* compileLayout -> scanLayout -> prepareLayout -> new WrappedBuilder
* isSafeString is no longer exported publicly. Is that intentional?
* normalizeTextValue is no longer exported publicly. Is that
* intentional?
* isComponentDefinition is gone, kind of replaced by
* `isCurriedComponentDefinition`. Neither is exported.
* getComponentDefintion is no longer part of Environment.
* referenceFromParts has been removed.
* f3444e9ae0c7751047bdcd856e61344bfb548e12
* readDOMAttr has been removed. 316805b9175e01698120b9566ec51c88d075026a
@rwjblue rwjblue added this to the v3.0.0 milestone Nov 7, 2017
@rwjblue
Copy link
Member

rwjblue commented Jan 19, 2018

GREEEEEEEEEEEEEEEEEEEEEEEEENNNNNNNNNN!!!!!

screenshot of passing ci

End users of `ember-source` do not need these dependencies...
@rwjblue rwjblue changed the title WIP: Upgrade glimmer-vm to latest Upgrade glimmer-vm to latest Jan 19, 2018
@rwjblue rwjblue merged commit 36ac96a into emberjs:master Jan 26, 2018
@jonnii
Copy link

jonnii commented Jan 26, 2018

@rwjblue what does this mean for ember users?

@rwjblue
Copy link
Member

rwjblue commented Jan 26, 2018

Not much. Just a dependency update. 😃

@SergeAstapov
Copy link
Contributor

@rwjblue does this update unblock rehydration for server-sider rendered apps?
If not - what else is blocking it unless "just needs to be done"?

@acorncom
Copy link
Contributor

@SergeAstapov there was some initial discussion of this on the Fastboot Slack channel. Because yes, folks are interested in exploring that now ... 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants