Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] missing modules docs for tryInvoke, compare, isEqual #16079 #16080

Merged

Conversation

Projects
None yet
2 participants
@jenweber
Copy link
Contributor

commented Jan 6, 2018

See #16079. This should target at least 2.18 LTS candidate and 3.0-beta. 2.16 LTS would be good too. I have no idea how any of that is done so let me know if I need to open more PRs against other branches.

Needs a good look by @toddjordan

Thank you to sukima for reporting!

@jenweber

This comment has been minimized.

Copy link
Contributor Author

commented Jan 6, 2018

The test suite passes locally.

CI fails at yarn install.
error An unexpected error occurred: "https://registry.yarnpkg.com/pinkie-promise/-/pinkie-promise-2.0.1.tgz: Request failed \"404 Not Found\"".

@jenweber

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2018

I added missing compare and isEqual which should belong to @ember/utils

docs here

@jenweber jenweber changed the title [BUGFIX] missing modules docs for tryInvoke and canInvoke #16079 WIP [BUGFIX] missing modules docs for tryInvoke, canInvoke, compare #16079 Jan 7, 2018

@jenweber jenweber changed the title WIP [BUGFIX] missing modules docs for tryInvoke, canInvoke, compare #16079 WIP [BUGFIX] missing modules docs for tryInvoke, canInvoke, compare, isEqual #16079 Jan 7, 2018

@jenweber jenweber force-pushed the jenweber:bugfix-tryinvoke-caninvoke-utils branch from a3251a5 to 84236ff Jan 7, 2018

@jenweber jenweber changed the title WIP [BUGFIX] missing modules docs for tryInvoke, canInvoke, compare, isEqual #16079 [BUGFIX] missing modules docs for tryInvoke, canInvoke, compare, isEqual #16079 Jan 7, 2018

@@ -30,7 +33,7 @@
```
@method isEqual

This comment has been minimized.

Copy link
@toddjordan

toddjordan Jan 8, 2018

Contributor

Also needs an @static to show up as a function

This comment has been minimized.

Copy link
@jenweber

jenweber Jan 8, 2018

Author Contributor

resolved

@@ -72,7 +76,7 @@ function spaceship(a, b) {
```
@method compare

This comment has been minimized.

Copy link
@toddjordan

toddjordan Jan 8, 2018

Contributor

needs an @static

This comment has been minimized.

Copy link
@jenweber

jenweber Jan 8, 2018

Author Contributor

resolved

@@ -12,7 +15,7 @@ import applyStr from './apply-str';
```
@method canInvoke

This comment has been minimized.

Copy link
@toddjordan

toddjordan Jan 8, 2018

Contributor

@static

This comment has been minimized.

Copy link
@jenweber

jenweber Jan 8, 2018

Author Contributor

I removed my changes to canInvoke - turns out it's not a package/module which makes sense because it is private API

@@ -35,7 +38,7 @@ export function canInvoke(obj, methodName) {
```
@method tryInvoke

This comment has been minimized.

Copy link
@toddjordan

toddjordan Jan 8, 2018

Contributor

@static

This comment has been minimized.

Copy link
@jenweber

jenweber Jan 8, 2018

Author Contributor

resolved

@jenweber

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2018

Thanks, I'll get those changes made

@jenweber jenweber force-pushed the jenweber:bugfix-tryinvoke-caninvoke-utils branch from a3cd4a0 to 689ffc5 Jan 8, 2018

@jenweber jenweber changed the title [BUGFIX] missing modules docs for tryInvoke, canInvoke, compare, isEqual #16079 [BUGFIX] missing modules docs for tryInvoke, compare, isEqual #16079 Jan 8, 2018

@jenweber

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2018

@toddjordan I added static to everything and double-checked that these methods are actually available in the utils module/package. canInvoke wasn't, so I reverted those changes.

@toddjordan

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2018

Tried it out. Looks good! Thanks @jenweber !!!

@toddjordan toddjordan merged commit db34024 into emberjs:master Jan 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.