Unify run loop setup. #16217
Merged
Unify run loop setup. #16217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the list of queue names was mutated _after_ the backburner instance was instantiated. This sort of private API manipulation is problematic because Backburner may move to an alternative internal structure. This also makes it much much easier to grok the actual queues in the system and their ordering...
This queue is _never_ intended to be scheduled into by anyone other than Ember itself, this change makes that much more likely.
|
@krisselden - This also makes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare run-loop queues in single centralized location.
Prior to this change the list of queue names was mutated after the backburner instance was instantiated. This sort of private API manipulation is problematic because Backburner may move to an alternative internal structure.
This also makes it much much easier to grok the actual queues in the system and their ordering...