Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some cleanup of CoreObject #16443

Closed
wants to merge 1 commit into from
Closed

some cleanup of CoreObject #16443

wants to merge 1 commit into from

Conversation

krisselden
Copy link
Contributor

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Mar 30, 2018

Test failed: Mixin#reopen:  using reopen() and calling _super where there is not a super function does not cause infinite recursion
    Failed assertion: expected: Breakfast!, but was: Your breakfast was interrupted by an infinite stack error.
    at _class.testUsingReopenAndCalling_superWhereThereIsNotASuperFunctionDoesNotCauseInfiniteRecursion [as @test using reopen() and calling _super where there is not a super function does not cause infinite recursion] (http://localhost:13141/ember-tests.js:46147:14)
    at Object.<anonymous> (http://localhost:13141/ember-tests.js:82042:31)
    at runTest (http://localhost:13141/qunit/qunit.js:1478:30)
    at Test.run (http://localhost:13141/qunit/qunit.js:1464:6)
    at http://localhost:13141/qunit/qunit.js:1670:12
    at Object.advance (http://localhost:13141/qunit/qunit.js:1116:26)

@@ -45,241 +45,225 @@ import {
const applyMixin = Mixin._apply;
const reopen = Mixin.prototype.reopen;

function makeCtor(base) {
// should use WeakSet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the PR moving weakset polyfill into Ember-utils package has landed, I think this can be updated

@rwjblue
Copy link
Member

rwjblue commented Apr 10, 2018

@krisselden - I'd hate to lose track of these changes, anything I can do to help?

@krisselden
Copy link
Contributor Author

this is superseded by #16757

@krisselden krisselden closed this Jun 21, 2018
@Turbo87 Turbo87 deleted the core-object branch December 26, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants