-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Update instance-initializer blueprint for ember-mocha 0.14 #17412
Conversation
}); | ||
afterEach(function() { | ||
<% if (destroyAppExists) { %>destroyApp(this.application);<% } else { %>run(this.application, 'destroy');<% } %> | ||
<% if (destroyAppExists) { %>destroyApp(this.instance);<% } else { %>run(this.instance, 'destroy');<% } %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would assume that the instance needs to be destroyed before the application.
@rwjblue thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, confirm, we should destroy the ApplicationInstance
instance before the Application
instance. (naming is hard 😭 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this!
Here's a separate PR for QUnit: #17712
2c15d76
to
d072143
Compare
d072143
to
5b0b146
Compare
Related to #16863
Note: this blueprint and the one for initializers (#17411) follow what the existing QUnit RFC232 blueprints do. However I wondered why for those qunit-based blueprints, the initializer test calls
setupTest()
, while the instance-initializer does not. For now the two new PRs for ember-mocha 0.14 do the same, but if there is no good reason for this, I can update all of those...