Update blueprints to use native JS classes #17621
Conversation
| @@ -13,6 +13,7 @@ const expect = chai.expect; | |||
|
|
|||
| const generateFakePackageManifest = require('../helpers/generate-fake-package-manifest'); | |||
| const enableModuleUnification = require('../helpers/module-unification').enableModuleUnification; | |||
| const enableOctane = require('../helpers/setup-test-environment').enableOctane; | |||
There was a problem hiding this comment.
I recommend to include the enableModuleUnification function into the /helpers/setup-test-environment module, but I would like to do that in an independent PR.
blueprints/native-detector.js
Outdated
|
|
||
| module.exports = function(blueprint) { | ||
| blueprint.filesPath = function() { | ||
| let rootPath = process.env.EMBER_VERSION === 'OCTANE' ? 'native-files' : 'files'; |
There was a problem hiding this comment.
For reference, we intend to come up with a better "flag" than process.env.EMBER_VERSION, but this unlocks actually being able to do the blueprint work while we figure that out.
ppcano
force-pushed
the
native-controller-blueprint
branch
from
3f1ddf8
to
698e8b5
Compare
|
@rwjblue, I have included the other blueprints and this is ready for merging now. Do we have also to support Native classes in the Ember Data blueprints? ember-cli/ember-octane-blueprint#37 is related to this PR in case you want to share your opinion on how/if to get rid of the |
ppcano
changed the title
|
|
||
| module.exports = function(blueprint) { | ||
| blueprint.filesPath = function() { | ||
| let rootPath = process.env.EMBER_VERSION === 'OCTANE' ? 'native-files' : 'files'; |
There was a problem hiding this comment.
Wasn't this edition in the blueprint? Am I misremembering?
There was a problem hiding this comment.
I don't understand the question.
Here is checking if the ENV.EMBER_VERSION is equal to 'OCTANEto use Native files instead of Emberextend`.
ember-cli/ember-octane-blueprint#36 set the env variable.
There was a problem hiding this comment.
ah ok, you right. I was misremembering. thank you! :)
Implements
Update blueprints for each object type to use native JS classesof #17234Related PRs ember-cli/ember-octane-blueprint#36 and ember-cli/ember-octane-blueprint#37