Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

Error: using ember-decorators blueprints instead of the ember blueprints. #37

Closed
ppcano opened this issue Feb 15, 2019 · 7 comments
Closed

Comments

@ppcano
Copy link
Contributor

ppcano commented Feb 15, 2019

The issue was previously reported at Discord. I am not sure if this is the correct repo to post this info.

Executing ember g controller foo-bar will generate the ember-decorator blueprints instead of the ember blueprints.

The ember-decorators blueprints don't include the latest MU fixes and they failed in some cases.

installing controller
  create app/controllers/foo-bar.js
installing controller-test
  create src/ui/routes/foo-bar/controller-test.js

At this moment, I am working on updating the Ember blueprint to use native classes at emberjs/ember.js#17621

@pzuraq what should it be the strategy to fix the issue?

A possible proposal:

  • Complete my PR and get merged.

  • Remove the ember-decorators blueprints.

  • Update the octane blueprint to use the new releases.

@ppcano ppcano changed the title Error: using ember-decorators blueprints instead of the ones provided by ember. Error: using ember-decorators blueprints instead of the ember blueprints. Feb 15, 2019
@rwjblue
Copy link
Member

rwjblue commented Feb 15, 2019

We should:

  • remove ember-decorators from this repo
  • enable the EMBER_NATIVE_DECORATOR_SUPPORT feature flag
  • enable the EMBER_METAL_TRACKED_PROPERTIES feature flag

@NullVoxPopuli
Copy link
Collaborator

I need to do some testing on this tonight. Been having issues with emberclear and native decorators

@NullVoxPopuli
Copy link
Collaborator

for those upgrading, we'll probably want to track whatever ends up being the solution to this:
image
(though, I still have ember-decorators)

@ppcano
Copy link
Contributor Author

ppcano commented Feb 16, 2019

@rwjblue Is this a change we can do at this moment, or do we have to wait for more progress on EMBER_NATIVE_DECORATOR_SUPPORT and EMBER_METAL_TRACKED_PROPERTIES?

@rwjblue
Copy link
Member

rwjblue commented Feb 16, 2019

I think we can do it now (at least enabling the two other flags). We might run into problems, but that’s why it’s important to test things...

@rwjblue
Copy link
Member

rwjblue commented Feb 16, 2019

Oh, also, we should add @glimmer/components addon (the most recent alpha release)

@NullVoxPopuli
Copy link
Collaborator

resolved by v0.4.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants