[RFC #435] Add feature flag and tests for forwarding modifiers with splattributes #17842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibernox
force-pushed
the
add-feature-flag-for-forwarding-modifiers
branch
2 times, most recently
from
3cb45e4
to
38c1322
Compare
rwjblue
approved these changes
Apr 2, 2019
cibernox
force-pushed
the
add-feature-flag-for-forwarding-modifiers
branch
from
38c1322
to
4c7b3a0
Compare
|
@rwjblue before merging I take that we should have a non-alpha release of glimmer containing that feature, right? |
chancancode
approved these changes
Apr 2, 2019
| }, | ||
| enter(node: AST.ElementNode) { | ||
| if (node.modifiers.length > 0 && isComponentInvocation(node)) { | ||
| assert(`Modifiers cannot be applied to components. ${calculateLocationDisplay( |
There was a problem hiding this comment.
nit: since we are about to roll this out/tech this to people, let’s avoid the “cannot be applied” wording, and go for something like “Passing modifiers to components require the xyz canary feature, which has not been stabilized yet. See RFC xyz for details.”
FEATURES.md
Outdated
| @@ -50,3 +50,10 @@ for a detailed explanation. | |||
| with the angle bracket invocation sytnax. | |||
|
|
|||
| See [RFC #459](https://github.com/emberjs/rfcs/pull/459). | |||
|
|
|||
| * `ember-glimmer-pass-modifiers-with-splattributes` | |||
There was a problem hiding this comment.
nit: pass -> forward to match the RFC title
cibernox
force-pushed
the
add-feature-flag-for-forwarding-modifiers
branch
from
4c7b3a0
to
cc1f387
Compare
… with splattributes
cibernox
force-pushed
the
add-feature-flag-for-forwarding-modifiers
branch
from
cc1f387
to
6e253dc
Compare
|
@chancancode updated |
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.