Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .volatile() #19670

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Remove .volatile() #19670

merged 1 commit into from
Jul 31, 2021

Conversation

nlfurniss
Copy link
Contributor

@nlfurniss nlfurniss commented Jul 22, 2021 •
edited

Part of #19617

Deprecation guide

Tests pass locally

@mixonic mixonic mentioned this pull request Jul 23, 2021
Closed
58 tasks
@nlfurniss nlfurniss requested a review from mixonic July 23, 2021 17:41
mixonic
mixonic approved these changes Jul 31, 2021
View reviewed changes
Copy link
Sponsor Member

@mixonic mixonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@mixonic mixonic merged commit c3a7fd9 into emberjs:master Jul 31, 2021
@nlfurniss nlfurniss deleted the remove-volatile branch July 31, 2021 18:19
@fsmanuel fsmanuel mentioned this pull request Aug 17, 2022
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixonic mixonic mixonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlfurniss @mixonic