[FEATURE ember-testing-lazy-routing] #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `setupForTesting` sets the application into testing mode (which is used to defer readiness. * Adds an initializer that defers readiness if the application is in testing mode. * `visit` helper has been updated to advance readiness upon first call. * `App.reset()` now behaves the same after `setupForTesting` (in a deferred state).
|
nice, going to try this in an app today. I'll merge or provide feedback once i've done so. |
ghost
assigned 
|
I just put this in my app and it seems to work great, got about a 10% time to run improvement on integration tests and it helps clean up a lot of LOG_TRANSITIONS noise. |
stefanpenner
added a commit
that referenced
this pull request
Nov 5, 2013
[FEATURE ember-testing-lazy-routing]
This was referenced Nov 5, 2013
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setupForTestingsets the application into testing mode (which is used to defer readiness).visithelper has been updated to advance readiness upon first call.App.reset()now behaves the same aftersetupForTesting(in a deferred state).