[BUGFIX beta] Move reduceComputed instanceMetas into object's meta #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hjdivad does this break anything? |
|
This seems totally reasonable. 🤘 @rjackson I'm surprised to see this unmerged. Isn't this one of the things we looked at yesterday? |
.
|
@rjackson ah I recall now; we just wanted to see a simple example to demonstrate it really does deal with the memory issue. Still, this seems like a definite improvement to me. |
mmun
changed the title
|
@rjackson I'm 👍 on shipping it. Demo is mostly good to verify the instanceMetas aren't also leaking elsewhere. |
rwjblue
added a commit
that referenced
this pull request
Mar 25, 2014
[BUGFIX beta] Move reduceComputed instanceMetas into object's meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4552. Also opens the door to new types of computed properties that require storing extra data related to caching, eg. throttled and debounced computed properties.