[DOC] Add action docs to input and textarea helpers #4755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation looks good, can you rebase? |
|
@ppcano - Can you rebase? |
|
@rwjblue, rebased and added new TextSupport documentation and missing tests. |
| @type String | ||
| @default undefined | ||
| */ | ||
| enter: undefined, |
There was a problem hiding this comment.
The docs are parsed completely unrelated to the actual JS, please do not actually define the property here (so it just ends up being the documentation block here).
|
@rwjblue, the doc has been cleaned up based on your comments and all the commits merged into one. |
rwjblue
added a commit
that referenced
this pull request
Jul 21, 2014
[DOC] Add action docs to input and textarea helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not find any doc to explain how input helpers can send actions. I am not sure it has been forgotten or it was intentionally done.
I think, there are still some steps to be completed:
TextSupportproperties of events (focus-in,focus-out...) likeaction.