Logic bug #5060
Closed
Logic bug #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks correct to me, could you add test illustrating the problem and showing that this is fixed? |
|
@ssured - Could you add a test to help make sure we don't accidentally regress? |
|
@ssured ping. |
|
@knownasilya do you mind adding the test for him? Would love to see this in |
|
@stefanpenner sure, I'll submit a PR. |
|
@knownasilya thank you kindly :) |
Closed
|
Closing in favor of PR. |
|
Ah, actually the other PR is just tests it looks like. |
|
@lukemelia i think we noticed this the other day aswell |
stefanpenner
added a commit
to stefanpenner/ember.js
that referenced
this pull request
Nov 1, 2014
|
This has been addressed by @stefanpenner's fix. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If compare is a function which returns
-1,0or1, then1-compare()has a result domain of2,1,0, which is wrong. I did not hit this bug, just encountered it while reading the source