#5060 compare tests

[knownasilya]

Not sure, but they don't return the results specified by OP of #5060. Might be botching the test..

[knownasilya]

Might not be passing the Comparable.detect test..

[knownasilya]

@rwjblue @stefanpenner any ideas why this might return an unexpected result?

Failed assertion: First item comparable - returns -1 (not negated), expected: -1, but was: 1
Failed assertion: First item comparable - returns 0 (not negated), expected: 0, but was: 1
Failed assertion: Second item comparable - returns -1 (negated), expected: 1, but was: -1
Failed assertion: Second item comparable - returns 0 (negated), expected: 0, but was: -1

[adamnemecek]

I think that there's an issue with the implementation of the compare function. It is supposed to take two arguments that it will compare, not return the value of the object.

[knownasilya]

@adamnemecek my implementation? Could you point me to where you see this?

[adamnemecek]

var Comp = EmberObject.extend(Comparable, {
  compare: function () {
    return this.get('val');
  }
});

I mean this. It's in your commit 8f2cab9.

[knownasilya]

@adamnemecek that's a way to force a compare result so I don't have to deal with writing a compare function. So I set what it should output, e.g. var comp1 = Comp.create({ val: -1 });

[knownasilya]

@adamnemecek not sure how to debug tests, so it's hard to see where the problem is. cc @rwjblue

[wagenet]

@rwjblue @stefanpenner ping