Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

Commit

Permalink
Merge pull request #69 from stevekinney/update-contributing-for-cli
Browse files Browse the repository at this point in the history
Update contributions section for CLI
  • Loading branch information
mixonic committed Mar 20, 2015
2 parents e185b8d + 45371c5 commit b6227f8
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions source/contributing/adding-new-features.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ problems with early return.
```js
if (Ember.FEATURES.isEnabled("feature")) {
// implementation
}
}
```

Tests will always run with all features on, so make sure that any tests
Expand All @@ -64,7 +64,7 @@ described above.

#### Feature Naming Conventions

```js
```config/environment.js
Ember.FEATURES["<packageName>-<feature>"] // if package specific
Ember.FEATURES["container-factory-injections"]
Ember.FEATURES["htmlbars"]
Expand All @@ -77,8 +77,16 @@ guarded by the conditionals in the original source. This means that
users of the canary build can enable whatever features they want by
enabling them before creating their Ember.Application.

```js
Ember.FEATURES["htmlbars"] = true;
```config/environment.js
module.exports = function(environment) {
var ENV = {
EmberENV: {
FEATURES: {
htmlbars: true
}
},
}
}
```

### `features.json`
Expand Down

0 comments on commit b6227f8

Please sign in to comment.