This repository has been archived by the owner on May 26, 2019. It is now read-only.
Update contributions section for CLI #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
| var ENV = { | ||
| EmberENV: { | ||
| FEATURES: { | ||
| Ember.FEATURES["htmlbars"] = true |
There was a problem hiding this comment.
https://github.com/ember-cli/ember-cli/pull/958/files#diff-9588ab8abb99afa6cac30dd0e2b86041R8
it should be
FEATURES: {
'htmlbars': true`
}
|
How so? |
|
Because it's using the global Ember.FEATURES hash |
|
Yea. Duh. Good point. You are totally right. On Thu, Mar 19, 2015 at 9:21 PM, Ricardo Mendes notifications@github.com
|
| @@ -44,7 +44,7 @@ problems with early return. | |||
| ```js | |||
| if (Ember.FEATURES.isEnabled("feature")) { | |||
There was a problem hiding this comment.
That would be in the Ember source code—not in a CLI project, I believe.
There was a problem hiding this comment.
technically it is ;-) but seems good
|
|
mixonic
added a commit
that referenced
this pull request
Mar 20, 2015
Update contributions section for CLI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the contribution guides section on feature flags for Ember CLI.