Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

[WIP] Update: Testing section to cli #61

Merged
merged 1 commit into from
Mar 24, 2015
Merged

[WIP] Update: Testing section to cli #61

merged 1 commit into from
Mar 24, 2015

Conversation

Serabe
Copy link
Member

@Serabe Serabe commented Mar 17, 2015

[WIP] Update the testing section to ember-cli.

@Serabe
Copy link
Member Author

Serabe commented Mar 17, 2015

@trek I started changing the naming for integration tests since ember-cli uses acceptance tests. Can I change the URL field too? I didn't do it just in case keeping the same URL is important somehow.

@Serabe Serabe changed the title Update: Testing section to cli [WIP] Update: Testing section to cli Mar 18, 2015
@joostdevries joostdevries mentioned this pull request Mar 18, 2015
Closed
19 tasks
@rwjblue
Copy link
Member

rwjblue commented Mar 18, 2015

The changes seem good to me, but @trek will need to weigh in on the url change...

@trek
Copy link
Member

trek commented Mar 18, 2015

url changes are fine.

@rwjblue
Copy link
Member

rwjblue commented Mar 18, 2015

@Serabe - Can you comment out the JSBin's in this section?

@Serabe
Copy link
Member Author

Serabe commented Mar 18, 2015

@rwjblue I'm going section by section changing and improving the guide trying to make sure the content is consistent with the rest of the testing guide. I guess my approach is a bit slower but I think is worth it so we can get a better final result.

If time is a hard constraint, I can do a fast conversion and go through it once again after that adding more consistency.

@Serabe
Copy link
Member Author

Serabe commented Mar 19, 2015

Should I add documentation about helpers behind a feature flag? Maybe commented out?

@trek
Copy link
Member

trek commented Mar 19, 2015

If time is a hard constraint, I can do a fast conversion and go through it once again after that adding more consistency.

I'm always 👍 on incremental improvements. I'd PR a quick pass and then continue work on a better fix.

@trek
Copy link
Member

trek commented Mar 19, 2015

Should I add documentation about helpers behind a feature flag? Maybe commented out?

Just leave them out for now. We haven't really thought about a strategy for beta docs yet.

@Serabe
Copy link
Member Author

Serabe commented Mar 19, 2015

I'll do the quick changes this night to be ready for tomorrow's new release. Then, I'll go on improving them bit by bit.

Thank you.

@Serabe
Copy link
Member Author

Serabe commented Mar 20, 2015

Quick status update:

  • In first place, sorry for the delay. I'll do my best to have it finished by tomorrow morning (I live in Madrid, Spain).
  • All jsbins from visible guides have been removed.
  • I'm having problems with custom test helpers after the qunit 2 upgrade. How do they get the assert object? How are they injected?
  • In the Testing Controllers guide, I've removed one section (the one that tests the component using acceptance test helpers) and commented out the one about nested components because I don't know how to load the template compiler. I would like confirmation about the removal part and would appreciate some guidance in the latter.

Again, sorry for the delay.

@Serabe
Copy link
Member Author

Serabe commented Mar 20, 2015

I forgot one question: should we remove the section about test runners since it is seems that ember-cli documentation is a better place for a guide about that? Furthermore, the information lying there is pretty much useless with ember-cli.

@trek
Copy link
Member

trek commented Mar 21, 2015

Looks good for a merge. Can you squash this?

@Serabe
Copy link
Member Author

Serabe commented Mar 21, 2015

@trek: squashed.

I have three questions left:

  • I'm having problems with custom test helpers after the qunit 2 upgrade. How do they get the assert object? How are they injected?
  • In the Testing Controllers guide, I've removed one section (the one that tests the component using acceptance test helpers) and commented out the one about nested components because I don't know how to load the template compiler. I would like confirmation about the removal part and would appreciate some guidance in the latter.
  • Should we remove the section about test runners since it is seems that ember-cli documentation is a better place for a guide about that? Furthermore, the information lying there is pretty much useless with ember-cli.

@trek
Copy link
Member

trek commented Mar 23, 2015

I'm having problems with custom test helpers after the qunit 2 upgrade. How do they get the assert object? How are they injected?

,

In the Testing Controllers guide, I've removed one section (the one that tests the component using acceptance test helpers) and commented out the one about nested components because I don't know how to load the template compiler. I would like confirmation about the removal part and would appreciate some guidance in the latter.

@rwjblue probably knows

Should we remove the section about test runners since it is seems that ember-cli documentation is a better place for a guide about that? Furthermore, the information lying there is pretty much useless with ember-cli.

Removal is fine

@Serabe
Copy link
Member Author

Serabe commented Mar 23, 2015

Thank you for your input, @trek. I have remove the section and improve the testing-helpers. Just in case, I keep the import Ember line since the guides need to focus only in the import part of the file.

If this is all ok, I'll squash them again so you can merge the PR.

Thank you.

@trek
Copy link
Member

trek commented Mar 24, 2015

👍 squash please

@Serabe
Upgrade testing guides to ember-cli
6626b17 
Change "Integration" to "Acceptance" tests.

Ember-CLI generator is `acceptance-test`, not `integration-test`.
This change aligns naming between the g

Change "Integration" to "Acceptance".

Ember-CLI nomenclature is "Acceptance test" and not "Integration test".

Minor changes to testing/index

Add comma and change adapter to addons.

Change Setup section to Introduction.

Since acceptance testing works in ember-cli out-of-the-box it makes no sense to
explain how to setup QUnit manually.

Remove section on third-party libraries.

This section seem to be far from the current way to create these adapters.
I would either remove the section entirely or create a new guide for writing
testing addons in ember-cli.

I'd appreciate some input from @trek.

Change integration URL to acceptance.

Update the testing helpers section to ember cli.

I might need some help with how to use them inside the startApp script since
the ember-cli example just imports them and that seems a bit strange.
//@trek

Update user interaction section.

Update unit testing basics.

Update Testing components section.

Section testing a component using acceptance helpers has been removed.
Section for nested components has been commented out until I figure out how to
load the template compiler in a test.

Remove jsbin from remaining guides.

Fix expect without assert first.

Update testing-routes guide.

Remove Ember imports.

Update testing-models guide.

Update testing-controllers.

Remove test-runners section.

This section is pointless now since ember-cli comes with most of these
features out of the box.

Improve section test-helpers.
@Serabe
Copy link
Member Author

Serabe commented Mar 24, 2015

@trek done!

trek added a commit that referenced this pull request Mar 24, 2015
@trek
Merge pull request #61 from Serabe/feature/testing-to-cli
07a8067 
[WIP] Update: Testing section to cli
@trek trek merged commit 07a8067 into emberjs:master Mar 24, 2015
@Serabe Serabe deleted the feature/testing-to-cli branch March 24, 2015 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Serabe @rwjblue @trek