Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

Update contributions section for CLI #69

Merged
merged 2 commits into from
Mar 20, 2015
Merged

Update contributions section for CLI #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfa4d37
Update contributions section for CLI
stevekinney Mar 19, 2015
45371c5
Remove global from feature flag
stevekinney Mar 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 12 additions & 4 deletions source/contributing/adding-new-features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ problems with early return.
```js
if (Ember.FEATURES.isEnabled("feature")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be in the Ember source code—not in a CLI project, I believe.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically it is ;-) but seems good

// implementation
}
}
```

Tests will always run with all features on, so make sure that any tests
Expand All @@ -64,7 +64,7 @@ described above.

#### Feature Naming Conventions

```js
```config/environment.js
Ember.FEATURES["<packageName>-<feature>"] // if package specific
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change this?

Ember.FEATURES["container-factory-injections"]
Ember.FEATURES["htmlbars"]
Expand All @@ -77,8 +77,16 @@ guarded by the conditionals in the original source. This means that
users of the canary build can enable whatever features they want by
enabling them before creating their Ember.Application.

```js
Ember.FEATURES["htmlbars"] = true;
```config/environment.js
module.exports = function(environment) {
var ENV = {
EmberENV: {
FEATURES: {
htmlbars: true
}
},
}
}
```

### `features.json`
Expand Down