-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: amendment to https://github.com/emberjs/rfcs/pull/391 #789
Comments
Good idea! |
@NullVoxPopuli is anything stopping you from making a draft RFC for this? |
time / motivation / work priorities 😅 |
Unless I'm misreading things, this doesn't strike me as a particularly hard RFC to write. Is there any way we could make the process simpler? |
I think in this particular case, it needs some planning / thinking through more use cases -- and then if the polaris / post-polaris routing efforts affect this? 🤔 having a lot of uncertainty around that kinda makes me feel uncertain about any routing changes at all -- which isn't good for anyone 🙃 |
@NullVoxPopuli on the one hand, I get that uncertainty here isn’t great. On the other, I’ve looked at the Router code and it’s very clear why nobody has made any significant changes recently! If a revamped router actually ships in timely fashion, I’d be thrilled! |
This has come up a bit as I've been discussing emberjs/ember.js#19271 and #391 with folks.
as is, I don't think #391's anchor-listener is able to be implemented as default behavior.
Mainly due to analytics.
I made a demo here showing that willRouteChange can be used for a lot of things.
But, if you want to do A/B testing with different call-to-action phrasings, we need some way to hook in to the transition/navigation logic (so that we can grab the clicked text)
I'd like to propose a couple options:
The text was updated successfully, but these errors were encountered: